Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • E ensembl
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Jira
    • Jira
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ensembl-gh-mirror
  • ensembl
  • Merge requests
  • !507

Merged
Created Aug 17, 2020 by Marek Szuba@mks

Fix travis build

  • Overview 2
  • Commits 3
  • Changes 8

Created by: mira13

Description

Fixing tests and travis build script. Befor in travia as a result was used variable that is always 0. So we had successful tests whatever is failed. After travis was fixed, it became obvious that some tests are not pasing, they are fixed as well - transcript, translation and gene tests. Few variables in sql requests were quoted, it doesn't make any difference in current sql, but makes code work in new sql server

detail of the fix: before, we took as a result last command output - $? , Last tests command is perl test run inside if statement, so when after if we took $? - it was result of if, but not the test run inside. Eventually of if obviously is always 0.

Use case

Travis test result was sucsessful, even if tests fails

Benefits

We have correct test system.

Possible Drawbacks

Still few more fails of tests are not covered in this branch, so it will be futher work

Testing

Yes, all tests now correct and pass I have run all them localy and on server

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: Bugfix/TestParsingErrors