Skip to content

ENSCORESW-3534: xref Database is also a DBConnection object

Marek Szuba requested to merge feature/xref_dbconnection into master

Created by: magaliruffier


  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion;
  • Review the contributing guidelines for this repository; remember in particular:
    • do not modify code without testing for regression
    • provide simple unit tests to test the changes
    • if you change the schema you must patch the test databases as well, see Updating the schema
    • the PR must not fail unit testing


Convert Database object to inherit from DBConnection

Use case

DBConnection has a large number of methods implemented to deal with database connection management. the Database object used in the xref pipeline is created from the DBConnection object by adding the ISA, the Database object also inherits all the methods from the DBConnection object


The Database object can use methods like disconnect_if_idle

Possible Drawbacks



Have you added/modified unit tests to test the changes? Tried running the ParseSource runnable by adding disconnect_if_idle onto the newly created Database object This fails with the master code (disconnect_if_idle not available) but works with this code change

If so, do the tests pass/fail?

Have you run the entire test suite and no regression was detected?

Merge request reports