Master

config/authsome.js

@@ -30,7 +30,8 @@ const authorisationMap = {
         admin: states,
         submitter: states.slice(0, states.length - 1),
         reviewer: states.slice(0, states.length - 1),
-        tagger: ['tagging', 'xml-triage'],
+        // taggers must be allowed to read in error state or cannot receive email
+        tagger: ['tagging', 'file-error'],
         'external-admin': ['xml-qa'],
       },
       entityAuthorisationAttribute: 'status',
@@ -50,7 +51,7 @@ const authorisationMap = {
       roles: {
         admin: states,
         submitter: ['INITIAL', 'READY', 'submission-error'],
-        reviewer: ['in-review', 'xml-review'],
+        reviewer: ['submission-error', 'in-review', 'xml-review'],
         tagger: ['tagging'],
         'external-admin': ['xml-qa'],
       },
@@ -71,6 +72,7 @@ const authorisationMap = {
       roles: {
         admin: states,
         submitter: states,
+        // allow reviewer and external QA to delete reviews
         reviewer: ['xml-review'],
         tagger: [],
         'external-admin': ['xml-qa'],