bugfix: more foolproof maths in triggers

sql/triggers.mysql

@@ -21,9 +21,12 @@ FOR EACH ROW
 CREATE TRIGGER update_job AFTER UPDATE ON job
 FOR EACH ROW
     UPDATE analysis_stats SET
-        unclaimed_job_count = unclaimed_job_count + (CASE NEW.status WHEN 'READY'  THEN 1 WHEN 'CLAIMED'   THEN -1 ELSE 0 END),
-        done_job_count      = done_job_count      + (CASE NEW.status WHEN 'DONE'   THEN 1 WHEN 'PASSED_ON' THEN  1 ELSE 0 END),
+        unclaimed_job_count = unclaimed_job_count + (CASE NEW.status WHEN 'READY'  THEN 1                          ELSE 0 END)
+                                                  - (CASE OLD.status WHEN 'READY'  THEN 1                          ELSE 0 END),
+        done_job_count      = done_job_count      + (CASE NEW.status WHEN 'DONE'   THEN 1 WHEN 'PASSED_ON' THEN  1 ELSE 0 END)
+                                                  - (CASE OLD.status WHEN 'DONE'   THEN 1 WHEN 'PASSED_ON' THEN  1 ELSE 0 END),
         failed_job_count    = failed_job_count    + (CASE NEW.status WHEN 'FAILED' THEN 1                          ELSE 0 END)
+                                                  - (CASE OLD.status WHEN 'FAILED' THEN 1                          ELSE 0 END)
     WHERE analysis_id = NEW.analysis_id;
 
 

sql/triggers.sqlite

@@ -26,9 +26,12 @@ CREATE TRIGGER update_job AFTER UPDATE ON job
 FOR EACH ROW
 BEGIN
     UPDATE analysis_stats SET
-        unclaimed_job_count = unclaimed_job_count + (CASE NEW.status WHEN 'READY'  THEN 1 WHEN 'CLAIMED'   THEN -1 ELSE 0 END),
-        done_job_count      = done_job_count      + (CASE NEW.status WHEN 'DONE'   THEN 1 WHEN 'PASSED_ON' THEN  1 ELSE 0 END),
+        unclaimed_job_count = unclaimed_job_count + (CASE NEW.status WHEN 'READY'  THEN 1                          ELSE 0 END)
+                                                  - (CASE OLD.status WHEN 'READY'  THEN 1                          ELSE 0 END),
+        done_job_count      = done_job_count      + (CASE NEW.status WHEN 'DONE'   THEN 1 WHEN 'PASSED_ON' THEN  1 ELSE 0 END) 
+                                                  - (CASE OLD.status WHEN 'DONE'   THEN 1 WHEN 'PASSED_ON' THEN  1 ELSE 0 END),
         failed_job_count    = failed_job_count    + (CASE NEW.status WHEN 'FAILED' THEN 1                          ELSE 0 END)
+                                                  - (CASE OLD.status WHEN 'FAILED' THEN 1                          ELSE 0 END)
     WHERE analysis_id = NEW.analysis_id;
 END;