added method AnalysisStatsAdaptor::increment_needed_workers

called when worker dies to replace itself in the needed_workers count since
it's decremented when it's born, and it's counted as living (and subtracted)
as long as it's running.  This gunarantees that another worker will quickly
be created after this one dies (and not need to wait for a synch to happen)

modules/Bio/EnsEMBL/Hive/DBSQL/AnalysisStatsAdaptor.pm

@@ -203,12 +203,22 @@ sub decrement_needed_workers
   my $self = shift;
   my $analysis_id = shift;
 
-  my $sql = "UPDATE analysis_stats SET num_required_workers=num_required_workers-1 ";
-  $sql .= " WHERE analysis_id='$analysis_id' ";
+  my $sql = "UPDATE analysis_stats SET num_required_workers=num_required_workers-1 ".
+            "WHERE analysis_id='$analysis_id' ";
 
-  my $sth = $self->prepare($sql);
-  $sth->execute();
-  $sth->finish;
+  $self->dbc->do($sql);
+}
+
+
+sub increment_needed_workers
+{
+  my $self = shift;
+  my $analysis_id = shift;
+
+  my $sql = "UPDATE analysis_stats SET num_required_workers=num_required_workers+1 ".
+            "WHERE analysis_id='$analysis_id' ";
+
+  $self->dbc->do($sql);
 }
 
 

modules/Bio/EnsEMBL/Hive/Queen.pm

@@ -174,8 +174,13 @@ sub register_worker_death {
     $self->db->get_AnalysisJobAdaptor->reset_dead_jobs_for_worker($worker);
   }
   
-  # re-sync the analysis_stats when a worker dies
-  $self->synchronize_AnalysisStats($worker->analysis->stats);
+  # re-sync the analysis_stats when a worker dies as part of dynamic sync system
+  if($self->synchronize_AnalysisStats($worker->analysis->stats)->status ne 'DONE') {
+    # since I'm dying I should make sure there is someone to take my place after I'm gone ...
+    # above synch still sees me as a 'living worker' so I need to compensate for that
+    $self->db->get_AnalysisStatsAdaptor->increment_needed_workers($worker->analysis->dbID);
+  }
+
 }
 
 
@@ -256,7 +261,7 @@ sub synchronize_AnalysisStats {
   return $analysisStats unless($analysisStats);
   return $analysisStats unless($analysisStats->analysis_id);
   return $analysisStats if(($analysisStats->status eq 'WORKING') and 
-			   ($analysisStats->seconds_since_last_update < 5*60));
+			   ($analysisStats->seconds_since_last_update < 3*60));
   
   return $analysisStats if(($analysisStats->status eq 'SYNCHING') and 
 			   ($analysisStats->seconds_since_last_update < 10*60));