Feature/open jdk

Created by: mira13

Requirements

• Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion;
• Review the development guidelines for eHive; remember in particular:
  • Do not modify code without testing for regression.
  • Provide simple unit tests to test the changes.
  • If you change the database schema, please follow the instructions for schema changes in the developer guidelines.
  • If you change the schema, meadow, or guest language interfaces, please follow the scheme for internal versioning in the developer guidelines.
  • The PR must not fail unit testing.

Use case

To avoid licence violation we must move to open jdk in Java wrapper

Description

move java wrapper to the latest JDK, in order to do it we need only change sun.misc.SharedSecrets lib import and RunWrapper.java call.

Possible Drawbacks

Won't work on JDK 11 and 10 as they have SharedSecrets in jdk.internal, and JDK 12 - 13 has this in jdk.access

Testing

Needs changes in travis installation (install JDK-13)

If so, do the tests pass/fail?

Have you run the entire test suite and no regression was detected?

Created by: mira13

Still in work, not for review.

Created by: codecov[bot]

Codecov Report

Merging #111 into version/2.5 will decrease coverage by 0.07%. The diff coverage is n/a.

@@               Coverage Diff               @@
##           version/2.5     #111      +/-   ##
===============================================
- Coverage        80.91%   80.83%   -0.08%     
===============================================
  Files              170      170              
  Lines             9906     9906              
  Branches          1601     1601              
===============================================
- Hits              8015     8008       -7     
- Misses            1234     1236       +2     
- Partials           657      662       +5

Impacted Files	Coverage Δ
modules/Bio/EnsEMBL/Hive/Scheduler.pm	78.03% <0%> (-1.52%)
modules/Bio/EnsEMBL/Hive/Valley.pm	88.17% <0%> (-1.08%)
modules/Bio/EnsEMBL/Hive/Queen.pm	68.8% <0%> (-0.8%)
modules/Bio/EnsEMBL/Hive/Worker.pm	65.63% <0%> (-0.29%)

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f69435c...1cb7da6. Read the comment docs.

Created by: coveralls

Coverage increased (+0.03%) to 87.038% when pulling 1cb7da6e on feature/open_jdk into f69435ce on version/2.5.

Created by: muffato

Why use JDK13 which is not out yet (it's "early access") instead of the released and maintained JDK12 (which has jdk.internal.access) ?

Created by: mira13

There is a small difference between 12 and 13, and considering how slow we are developing, 12 will become old very fast