Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • E ensembl-io
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Jira
    • Jira
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Terraform modules
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ensembl-gh-mirror
  • ensembl-io
  • Merge requests
  • !55

Rework on how Bio::DB::HTS is used in HTSAdaptor

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Marek Szuba requested to merge github/fork/Zhicheng-Liu/bugfix/ENSEMBL-5035 into master Jun 28, 2017
  • Overview 10
  • Commits 2
  • Pipelines 0
  • Changes 1

Created by: Zhicheng-Liu

The Bio::DB::HTS object and other relatedHTS objects will be created only once within a single HTSAdaptor. They will have only one copy and be stored in $self->{_cache}->{_htsobj_handle}. Every use of HTS objects should through this copy.

Also remove "close" calls to the HTS objects as these objects will handle their resources properly when exiting. The DESTROY methods to these objects has been added in https://github.com/Ensembl/Bio-DB-HTS/pull/50 which will release the resources where needed.

This will provide a uniform interface to HTS objects, making it more consistent. It prevents from creating multiple objects for the same file and hence more resouces efficient too.

Also rename some variables to make them consistent throughout.

Related to ENSEMBL-5035.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/Zhicheng-Liu/bugfix/ENSEMBL-5035