Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • E ensembl-test
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Jira
    • Jira
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ensembl-gh-mirror
  • ensembl-test
  • Merge requests
  • !20

Closed
Created Mar 06, 2018 by Marek Szuba@mks
  • Report abuse
Report abuse

explicitly check for SQLite db driver

  • Overview 3
  • Commits 1
  • Changes 1

Created by: tgrego

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion;
  • Review the contributing guidelines for this repository; remember in particular:
    • do not modify code without testing for regression
    • provide simple unit tests to test the changes
    • the PR must not fail unit testing

Description

One or more sentences describing in detail the proposed changes.

when running the patch_test_databases.pl script, we get the following error message:

DBIx::Class::Storage::DBI::sql_maker(): Your storage class (DBIx::Class::Storage::DBI) does not set sql_limit_dialect and you have not supplied an explicit limit_dialect in your connection_info. DBIC will attempt to use the GenericSubQ dialect, which works on most databases but can be (and often is) painfully slow. Please file an RT ticket against 'DBIx::Class::Storage::DBI' at dump_test_schema.pl line 168

this is caused by the following call: https://github.com/Ensembl/ensembl-test/blob/release/91/scripts/dump_test_schema.pl#L168

might be a version issue

Use case

Describe the problem. Please provide an example representing the motivation behind the need for having these changes in place.

Explicitly providing --check_driver "SQLite" flag to the dump_test_schema.pl call in convert_test_schemas.sh solves this issue.

Benefits

If applicable, describe the advantages the changes will have.

Stopping the error message.

Possible Drawbacks

If applicable, describe any possible undesirable consequence of the changes.

convert_test_schemas.sh is to my knowledge only called from convert_sqllite() method in patch_test_databases.pl. This is always using SQLite driver.

Testing

Have you added/modified unit tests to test the changes?

No.

If so, do the tests pass/fail?

Pass, of course.

Have you run the entire test suite and no regression was detected?

Yes.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: github/fork/tgrego/ENSCORESW-2622