Skip to content

explicitly check for SQLite db driver

Marek Szuba requested to merge github/fork/tgrego/ENSCORESW-2622 into master

Created by: tgrego


  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion;
  • Review the contributing guidelines for this repository; remember in particular:
    • do not modify code without testing for regression
    • provide simple unit tests to test the changes
    • the PR must not fail unit testing


One or more sentences describing in detail the proposed changes.

when running the script, we get the following error message:

DBIx::Class::Storage::DBI::sql_maker(): Your storage class (DBIx::Class::Storage::DBI) does not set sql_limit_dialect and you have not supplied an explicit limit_dialect in your connection_info. DBIC will attempt to use the GenericSubQ dialect, which works on most databases but can be (and often is) painfully slow. Please file an RT ticket against 'DBIx::Class::Storage::DBI' at line 168

this is caused by the following call:

might be a version issue

Use case

Describe the problem. Please provide an example representing the motivation behind the need for having these changes in place.

Explicitly providing --check_driver "SQLite" flag to the call in solves this issue.


If applicable, describe the advantages the changes will have.

Stopping the error message.

Possible Drawbacks

If applicable, describe any possible undesirable consequence of the changes. is to my knowledge only called from convert_sqllite() method in This is always using SQLite driver.


Have you added/modified unit tests to test the changes?


If so, do the tests pass/fail?

Pass, of course.

Have you run the entire test suite and no regression was detected?


Merge request reports