Skip to content

explicitly check for SQLite db driver

Marek Szuba requested to merge github/fork/tgrego/ENSCORESW-2622 into master

Created by: tgrego

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion;
  • Review the contributing guidelines for this repository; remember in particular:
    • do not modify code without testing for regression
    • provide simple unit tests to test the changes
    • the PR must not fail unit testing

Description

One or more sentences describing in detail the proposed changes.

when running the patch_test_databases.pl script, we get the following error message:

DBIx::Class::Storage::DBI::sql_maker(): Your storage class (DBIx::Class::Storage::DBI) does not set sql_limit_dialect and you have not supplied an explicit limit_dialect in your connection_info. DBIC will attempt to use the GenericSubQ dialect, which works on most databases but can be (and often is) painfully slow. Please file an RT ticket against 'DBIx::Class::Storage::DBI' at dump_test_schema.pl line 168

this is caused by the following call: https://github.com/Ensembl/ensembl-test/blob/release/91/scripts/dump_test_schema.pl#L168

might be a version issue

Use case

Describe the problem. Please provide an example representing the motivation behind the need for having these changes in place.

Explicitly providing --check_driver "SQLite" flag to the dump_test_schema.pl call in convert_test_schemas.sh solves this issue.

Benefits

If applicable, describe the advantages the changes will have.

Stopping the error message.

Possible Drawbacks

If applicable, describe any possible undesirable consequence of the changes.

convert_test_schemas.sh is to my knowledge only called from convert_sqllite() method in patch_test_databases.pl. This is always using SQLite driver.

Testing

Have you added/modified unit tests to test the changes?

No.

If so, do the tests pass/fail?

Pass, of course.

Have you run the entire test suite and no regression was detected?

Yes.

Merge request reports