Skip to content
Snippets Groups Projects
Commit 3c741942 authored by Andreas Kusalananda Kähäri's avatar Andreas Kusalananda Kähäri
Browse files

POD for fetch_all_by_Slice_and_pid() says an exception is thrown if

argument $pid is not defined, even though it isn't and even though $pid
is optional.  Fixed.
parent c657a247
No related branches found
No related tags found
No related merge requests found
......@@ -151,31 +151,31 @@ sub fetch_all_by_Slice_and_external_db {
$logic_name will be returned.
Returntype : listref of Bio::EnsEMBL::BaseAlignFeatures
in Slice coordinates
Exceptions : thrown if pid is not defined
Exceptions : none
Caller : general
Status : Stable
=cut
sub fetch_all_by_Slice_and_pid {
my ($self,$slice,$pid, $logic_name) = @_;
my $constraint;
my ( $self, $slice, $pid, $logic_name ) = @_;
# #get the primary table alias
# my @tabs = $self->_tables;
# my $alias = $tabs[0]->[1];
# #get the primary table alias
# my @tabs = $self->_tables;
# my $alias = $tabs[0]->[1];
# if(defined $pid) {
# $constraint = "${alias}.perc_ident > $pid";
# }
# if(defined $pid) {
# $constraint = "${alias}.perc_ident > $pid";
# }
if(defined $pid){
my $constraint;
if ( defined($pid) ) {
$constraint = "perc_ident > $pid";
}
return $self->fetch_all_by_Slice_constraint($slice, $constraint,
$logic_name);
return
$self->fetch_all_by_Slice_constraint( $slice, $constraint,
$logic_name );
}
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment