Skip to content
Snippets Groups Projects
Unverified Commit 4a7bf4f0 authored by Premanand Achuthan's avatar Premanand Achuthan Committed by GitHub
Browse files

Merge pull request #298 from Ensembl/create_release_tasks-scalar_keys

create_release_tasks.pl: explicitly dereference arguments to 'keys'
parents 20a75ad9 295985e9
No related branches found
No related tags found
2 merge requests!342Feature/schema update 96,!342Feature/schema update 96
......@@ -258,7 +258,7 @@ sub validate_parameters {
$parameters->{config} );
print "Dates:\n";
foreach my $date_label (keys $parameters->{dates}) {
foreach my $date_label (keys %{$parameters->{dates}}) {
printf( "%33s: %s\n",
$date_label,
$parameters->{dates}->{$date_label} );
......@@ -518,7 +518,7 @@ sub replace_placeholders {
}
}
for my $param (keys $parameters->{dates}) {
for my $param (keys %{$parameters->{dates}}) {
if($line =~ /<$param>/) {
$line =~ s/<$param>/$parameters->{dates}->{$param}/eg;
}
......@@ -698,7 +698,7 @@ sub fetch_dates {
my $events = $hash->{events};
foreach my $milestone_name (keys $parameters->{ical}) {
foreach my $milestone_name (keys %{$parameters->{ical}}) {
my $calendar_label = $parameters->{ical}->{$milestone_name};
$calendar_label = replace_placeholders($calendar_label, $parameters);
print "Looking for '$calendar_label' in ical...";
......@@ -735,9 +735,9 @@ sub find_event_by_name {
my ( $label, $events ) = @_;
foreach my $year (keys %$events) {
foreach my $month (keys $events->{$year}) {
foreach my $day (keys $events->{$year}->{$month}) {
foreach my $event (keys $events->{$year}->{$month}->{$day} ) {
foreach my $month (keys %{$events->{$year}}) {
foreach my $day (keys %{$events->{$year}->{$month}}) {
foreach my $event (keys %{$events->{$year}->{$month}->{$day}} ) {
if($events->{$year}->{$month}->{$day}->{$event}->{SUMMARY} eq $label) {
return $events->{$year}->{$month}->{$day}->{$event};
}
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment