[ENSCORESW-1726] Deprecate dump_data() functionality now provided by dna_align_feature_attrib.

DEPRECATED.md

@@ -8,6 +8,11 @@ When a method is deprecated, a deprecation warning is thrown whenever the method
 The warning also contains instructions on replacing the deprecated method and when it will be removed.
 A year after deprecation (4 Ensembl releases), the method is removed from the API.
 
+### Removed in Ensembl Release 91 ###
+
+ - Bio::EnsEMBL::DBSQL::**BaseAdaptor**::*dump_data()*
+ - Bio::EnsEMBL::DBSQL::**BaseAdaptor**::*get_dumped_data()*
+
 ### Removed in Ensembl Release 88 ###
 
  - Bio::EnsEMBL::**Slice**::*get_all_VariationFeatures()*

modules/Bio/EnsEMBL/DBSQL/BaseAdaptor.pm

@@ -92,8 +92,6 @@ case the convention is to go list_XXXX, such as
 
 (note: this method is poorly named)
 
-=head1 METHODS
-
 =cut
 
 package Bio::EnsEMBL::DBSQL::BaseAdaptor;
@@ -101,7 +99,7 @@ require Exporter;
 use vars qw(@ISA @EXPORT);
 use strict;
 
-use Bio::EnsEMBL::Utils::Exception qw(throw);
+use Bio::EnsEMBL::Utils::Exception qw(throw deprecate);
 use Bio::EnsEMBL::Utils::Scalar qw(assert_ref assert_integer wrap_array);
 use DBI qw(:sql_types);
 use Data::Dumper;
@@ -1096,7 +1094,7 @@ sub _build_id_cache {
 sub dump_data {
   my $self = shift;
   my $data = shift;
-
+  deprecate('This method is deprecated and will be removed in e91. Please use the get_all_attributes() and add_attributes() methods of DnaDnaAlignFeature instead. In the more general case, many feature types allow attributes to be stored as well');
   my $dumper = Data::Dumper->new([$data]);
   $dumper->Indent(0);
   $dumper->Terse(1);
@@ -1109,7 +1107,7 @@ sub dump_data {
 sub get_dumped_data {
     my $self = shift;
     my $data = shift;
-
+    deprecate('This method is deprecated and will be removed in e91. Please use the get_all_attributes() and add_attributes() methods of DnaDnaAlignFeature instead. In the more general case, many feature types allow attributes to be stored as well');
     $data =~ s/\n|\r|\f|(\\\\)//g;
     return eval ($data); ## no critic
 }