Merge pull request #406 from Ensembl/update_perl_critic_tidy_configs

Update PerlCritic and PerlTidy configuration

.perlcriticrc

+severity  = 1
+color = 1
+color-severity-highest = red
+color-severity-high = magenta
+color-severity-medium = yellow
+
+[Subroutines::ProhibitExplicitReturnUndef]
+severity=4
+
+[CodeLayout::ProhibitHardTabs]
+allow_leading_tabs = 0
+
+[CodeLayout::RequireTidyCode]
+perltidyrc = .perltidyrc
+
+[Subroutines::ProhibitUnusedPrivateSubroutines]
+allow = _init_db _init_config _guess_config
+
+[Subroutines::ProhibitUnusedPrivateSubroutines]
+skip_when_using = Moose
+
+[Subroutines::ProhibitManyArgs]
+max_arguments = 7

modules/t/housekeeping_perlCritic.t

@@ -46,7 +46,7 @@ chdir($original_dir);
 my $root = File::Spec->catdir($cur_dir, File::Spec->updir(),File::Spec->updir());
 
 # Configure critic
-Test::Perl::Critic->import(-profile => File::Spec->catfile($root, 'perlcriticrc'), -severity => 5, -verbose => 8);
+Test::Perl::Critic->import(-profile => File::Spec->catfile($root, '.perlcriticrc'), -severity => 5, -verbose => 8);
 
 #Find all files & run
 my @perl_files = Perl::Critic::Utils::all_perl_files(

perlcriticrc

-severity  = 5
-
-[Subroutines::ProhibitExplicitReturnUndef]
-severity=4
\ No newline at end of file