Skip to content
Snippets Groups Projects
Commit f71761ff authored by Alessandro Vullo's avatar Alessandro Vullo Committed by GitHub
Browse files

Merge pull request #194 from Zhicheng-Liu/improvement/get_all_dba

Return all adaptors in the registry in get_all_DBAdaptors if no args …
parents 985f2e36 ac4fd78d
No related branches found
No related tags found
No related merge requests found
......@@ -669,6 +669,10 @@ sub get_all_DBAdaptors {
my ( $species, $group ) = rearrange( [qw(SPECIES GROUP)], @args );
if ( !defined($species) && !defined($group) ) {
return $registry_register{'_DBA'};
}
if ( defined($species) ) {
$species = $class->get_alias($species);
return [] unless $species;
......
......@@ -18,6 +18,7 @@ use warnings;
use Config;
use Test::More;
use Test::Deep;
use Test::Warnings;
use Test::Exception;
use File::Temp qw/tempfile/;
......@@ -127,6 +128,10 @@ my @species = @{ $reg->get_all_species() };
ok(scalar(@species) == 1, "get_all_species");
ok(scalar(@{ $reg->get_all_species('cahoona') }) == 0, "get_all_species with bogus data.");
# Test get_all_DBAdaptors
my $registry_register_dba = $Bio::EnsEMBL::Registry::registry_register{'_DBA'};
is( scalar(@{$reg->get_all_DBAdaptors()}), scalar(@{$registry_register_dba}), "get_all_DBAdaptors() on all species and groups" );
cmp_deeply( $reg->get_all_DBAdaptors(), shallow($registry_register_dba), "get_all_DBAdaptors() on all species and groups: comparing references" );
ok(scalar(@{$reg->get_all_DBAdaptors(-SPECIES => $species[0])}), "get_all_DBAdaptors() on a valid species");
warns_like(
sub { is(scalar(@{$reg->get_all_DBAdaptors(-SPECIES => 'cahoona')}), 0, "get_all_DBAdaptors() on a non-existing species"); },
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment