Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • E ensembl
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Jira
    • Jira
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Terraform modules
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ensembl-gh-mirror
  • ensembl
  • Merge requests
  • !402

Prevent ChecksumParser from losing one xref per input file

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Marek Szuba requested to merge bugfix/checksumparser_id_off_by_one into master Jul 25, 2019
  • Overview 3
  • Commits 3
  • Pipelines 0
  • Changes 1

Created by: mkszuba

Description

Shift the numbering of checksum xrefs to be inserted by ChecksumParser by one. Also, check if the temporary output file has successfully been opened before attempting to use it.

Use case

The way ChecksumParser calculates values of checksum_xref_id now causes it to lose one such xref per input file; see the commit message for details. May or may not be related to ENSCORESW-3196.

Benefits

Will stop losing RNAcentral and UniParc xrefs.

Possible Drawbacks

None.

Testing

Have you added/modified unit tests to test the changes?

No.

If so, do the tests pass/fail?

N/A

Have you run the entire test suite and no regression was detected?

No, ChecksumParser is not covered by the test suite.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: bugfix/checksumparser_id_off_by_one