Skip to content

Prevent ChecksumParser from losing one xref per input file

Marek Szuba requested to merge bugfix/checksumparser_id_off_by_one into master

Created by: mkszuba

Description

Shift the numbering of checksum xrefs to be inserted by ChecksumParser by one. Also, check if the temporary output file has successfully been opened before attempting to use it.

Use case

The way ChecksumParser calculates values of checksum_xref_id now causes it to lose one such xref per input file; see the commit message for details. May or may not be related to ENSCORESW-3196.

Benefits

Will stop losing RNAcentral and UniParc xrefs.

Possible Drawbacks

None.

Testing

Have you added/modified unit tests to test the changes?

No.

If so, do the tests pass/fail?

N/A

Have you run the entire test suite and no regression was detected?

No, ChecksumParser is not covered by the test suite.

Merge request reports