Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • E ensembl
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Jira
    • Jira
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Terraform modules
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ensembl-gh-mirror
  • ensembl
  • Merge requests
  • !435

Enscoresw 3267

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Marek Szuba requested to merge ENSCORESW-3267 into master Nov 01, 2019
  • Overview 2
  • Commits 2
  • Pipelines 0
  • Changes 39

Created by: ameya1981

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion;
  • Review the contributing guidelines for this repository; remember in particular:
    • do not modify code without testing for regression
    • provide simple unit tests to test the changes
    • if you change the schema you must patch the test databases as well, see Updating the schema
    • the PR must not fail unit testing

Description

Make 'type' column in core.external_db table to NOT NULL

Use case

As requested in ENSINT-307 Healtchecks were checking for Not Null, but table was allowing null values.

Benefits

The health-check can be deprecated

Possible Drawbacks

Value needs to be entered even if not applicable

Testing

No unit tests changed

If so, do the tests pass/fail? N/A

Have you run the entire test suite and no regression was detected? No regression detected

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: ENSCORESW-3267