Skip to content

Enscoresw 3267

Marek Szuba requested to merge ENSCORESW-3267 into master

Created by: ameya1981

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion;
  • Review the contributing guidelines for this repository; remember in particular:
    • do not modify code without testing for regression
    • provide simple unit tests to test the changes
    • if you change the schema you must patch the test databases as well, see Updating the schema
    • the PR must not fail unit testing

Description

Make 'type' column in core.external_db table to NOT NULL

Use case

As requested in ENSINT-307 Healtchecks were checking for Not Null, but table was allowing null values.

Benefits

The health-check can be deprecated

Possible Drawbacks

Value needs to be entered even if not applicable

Testing

No unit tests changed

If so, do the tests pass/fail? N/A

Have you run the entire test suite and no regression was detected? No regression detected

Merge request reports