Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • Z zircon
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Jira
    • Jira
  • Merge requests 0
    • Merge requests 0
  • Requirements
    • Requirements
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
    • Value stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ensembl-gh-mirror
  • zircon
  • Merge requests
  • !1

Merged
Created Feb 06, 2019 by Marek Szuba@mks

Fix precedence problem by replacing or with ||

  • Overview 1
  • Commits 3
  • Changes 1

Created by: thibauthourlier

Since Perl 5.22, it warns of possible precedence problem it cases like : return $value or die('Sad'); return $value is tested, not $value. It can be fixed by either using || or by using () around the test. The problem was already there in earlier versions of Perl but no waring was issued.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: github/fork/thibauthourlier/feature/fix_return_or