Skip to content
Snippets Groups Projects
Commit 2169ce8b authored by Alex Clemmer's avatar Alex Clemmer Committed by GitHub
Browse files

Merge pull request #170 from jessicayuen/default-namespace-fix

Remove unnecessary param from defaultNamespace()
parents a336ad8f c95cde93
No related branches found
No related tags found
No related merge requests found
...@@ -108,7 +108,7 @@ var applyCmd = &cobra.Command{ ...@@ -108,7 +108,7 @@ var applyCmd = &cobra.Command{
return err return err
} }
c.DefaultNamespace, err = defaultNamespace(clientConfig) c.DefaultNamespace, err = defaultNamespace()
if err != nil { if err != nil {
return err return err
} }
......
...@@ -71,7 +71,7 @@ var deleteCmd = &cobra.Command{ ...@@ -71,7 +71,7 @@ var deleteCmd = &cobra.Command{
return err return err
} }
c.DefaultNamespace, err = defaultNamespace(clientConfig) c.DefaultNamespace, err = defaultNamespace()
if err != nil { if err != nil {
return err return err
} }
......
...@@ -69,7 +69,7 @@ var diffCmd = &cobra.Command{ ...@@ -69,7 +69,7 @@ var diffCmd = &cobra.Command{
return err return err
} }
c.DefaultNamespace, err = defaultNamespace(clientConfig) c.DefaultNamespace, err = defaultNamespace()
if err != nil { if err != nil {
return err return err
} }
......
...@@ -122,11 +122,11 @@ var RootCmd = &cobra.Command{ ...@@ -122,11 +122,11 @@ var RootCmd = &cobra.Command{
// clientConfig.Namespace() is broken in client-go 3.0: // clientConfig.Namespace() is broken in client-go 3.0:
// namespace in config erroneously overrides explicit --namespace // namespace in config erroneously overrides explicit --namespace
func defaultNamespace(c clientcmd.ClientConfig) (string, error) { func defaultNamespace() (string, error) {
if overrides.Context.Namespace != "" { if overrides.Context.Namespace != "" {
return overrides.Context.Namespace, nil return overrides.Context.Namespace, nil
} }
ns, _, err := c.Namespace() ns, _, err := clientConfig.Namespace()
return ns, err return ns, err
} }
......
...@@ -84,7 +84,7 @@ local configuration. Accepts JSON, YAML, or Jsonnet.`, ...@@ -84,7 +84,7 @@ local configuration. Accepts JSON, YAML, or Jsonnet.`,
return err return err
} }
c.DefaultNamespace, err = defaultNamespace(clientConfig) c.DefaultNamespace, err = defaultNamespace()
if err != nil { if err != nil {
return err return err
} }
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment