Address ansible-lint errors

.gitlab-ci.yml

@@ -5,4 +5,4 @@ ansible-lint:   # Validate ansible configuration
   stage: validate
   image: registry.gitlab.com/pipeline-components/ansible-lint:latest
   script:
-    - ansible-lint --show-relpath
\ No newline at end of file
+    - ansible-lint --show-relpath

playbooks/eduroam.yaml

@@ -10,22 +10,20 @@
         msg: "This playbook must be run as your own user account."
       when: ansible_user_id == "root"
     - name: Remove existing Eduroam Wi-Fi Network
-      ansible.builtin.shell:
+      ansible.builtin.command:
         cmd: /usr/bin/nmcli connection delete eduroam
       ignore_errors: true
     - name: Add Eduroam Wi-Fi Network
-      ansible.builtin.shell:
+      ansible.builtin.command:
         cmd: >
-          /usr/bin/nmcli connection add con-name eduroam 
-          type wifi 
-          ssid eduroam 
-          connection.permissions {{ ansible_user_id }} 
-          connection.autoconnect-priority -10 
-          wifi-sec.key-mgmt wpa-eap 
-          802-1x.eap peap 
-          802-1x.anonymous-identity "@ebi.ac.uk" 
-          802-1x.identity "{{ ansible_user_id }}@ebi.ac.uk" 
-          802-1x.phase2-auth mschapv2 
+          /usr/bin/nmcli connection add con-name eduroam
+          type wifi
+          ssid eduroam
+          connection.permissions {{ ansible_user_id }}
+          connection.autoconnect-priority -10
+          wifi-sec.key-mgmt wpa-eap
+          802-1x.eap peap
+          802-1x.anonymous-identity "@ebi.ac.uk"
+          802-1x.identity "{{ ansible_user_id }}@ebi.ac.uk"
+          802-1x.phase2-auth mschapv2
           802-1x.system-ca-certs true
-
-                
\ No newline at end of file

playbooks/network_reset.yaml

@@ -3,10 +3,8 @@
 - name: Reset Network Services
   hosts: localhost
   tasks:
-    - ansible.builtin.import_tasks: ../tasks/require_sudo.yaml
-#    - name: Re-apply Netplan Configuration
-#      ansible.builtin.script:
-#        cmd: '/usr/sbin/netplan apply'
+    - name: Import tasks
+      ansible.builtin.import_tasks: ../tasks/require_sudo.yaml
     - name: Restart NetworkManager
       ansible.builtin.service:
         name: NetworkManager
@@ -14,4 +12,4 @@
     - name: Restart DNS
       ansible.builtin.service:
         name: systemd-resolved
-        state: restarted
\ No newline at end of file
+        state: restarted

tasks/require_sudo.yaml

 ---
-  - name: Privilege Escalation
-    ansible.builtin.fail:
-      msg: "This playbook must be run with elevated permissions. Please re-run with sudo."
-    when: ansible_user_id != "root"
\ No newline at end of file
+- name: Privilege Escalation
+  ansible.builtin.fail:
+    msg: "This playbook must be run with elevated permissions. Please re-run with sudo."
+  when: ansible_user_id != "root"