detailed descriptions for notification settings

app/components/login/Login.jsx

@@ -114,10 +114,7 @@ class Login extends React.Component {
             if (loading || !data) return null
             const { display, startDate, stopDate } = data.findProp.value
             if (!display) return null
-            if (
-              moment().isBefore(`${startDate.date}T${startDate.time}`) ||
-              moment().isAfter(`${stopDate.date}T${startDate.time}`)
-            )
+            if (moment().isAfter(`${stopDate.date}T${startDate.time}`))
               return null
             return (
               <Holiday

server/xpub-model/seeds/config_seed.js

@@ -5,7 +5,8 @@ exports.seed = async (knex, Promise) => {
   const seeds = [
     {
       name: 'homeNotification',
-      description: 'Login page notification settings',
+      description:
+        'Login page notification settings. Checkbox must be checked for notification to appear, even when prescheduled. If dates are included, the notification will appear only after the start date and before the end date.',
       schema: JSON.stringify({
         type: 'object',
         properties: {
@@ -76,7 +77,8 @@ exports.seed = async (knex, Promise) => {
     },
     {
       name: 'holidayNotification',
-      description: 'Login page holiday notice settings',
+      description:
+        'Login page holiday notice settings. Start and end dates of the holiday period are required for the message text. Only the checkbox and end date are used for display calculations; if the checkbox is checked the notification will appear until the end date.',
       schema: JSON.stringify({
         type: 'object',
         properties: {