Use transactions in grant link check

server/ebi-integration/grantLinkCheck.js

@@ -4,6 +4,7 @@ const Manuscript = require('../xpub-model/entities/manuscript/data-access')
 const {
   gManuscript,
 } = require('../xpub-model/entities/manuscript/helpers/transform')
+const { transaction } = require('objection')
 const { errorDevEmail } = require('../email')
 const { createGrantLinks } = require('./linkGrants')
 
@@ -45,6 +46,7 @@ process
   })
 
 async function grantLinkCheck() {
+  const trx = await transaction.start(Manuscript.knex())
   try {
     const linkingManuscripts = await Manuscript.query()
       .where('ncbiState', 'linking grants')
@@ -56,18 +58,20 @@ async function grantLinkCheck() {
       if (!grantLinkDone.success) {
         throw new Error(grantLinkDone.message)
       }
-      await Promise.all(
-        linkingManuscripts.map(async m => {
-          m.ncbiState = 'success'
-          await m.save()
-          return true
-        }),
-      )
+      await linkingManuscripts.reduce(async (promise, m) => {
+        await promise
+        m.ncbiState = 'success'
+        await m.saveWithTrx(trx)
+        return Promise.resolve()
+      }, Promise.resolve())
+      trx.commit()
       return true
     }
     logger.info('No grant links to send.')
+    if (trx) await trx.rollback()
     return true
   } catch (e) {
+    if (trx) await trx.rollback()
     await errorDevEmail('sending grants to EBI', e)
     logger.error(`Unable to get or send grant links: ${e}`)
     throw e