Skip to content
GitLab
Projects
Groups
Snippets
Help
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Sign in
Toggle navigation
Open sidebar
ensembl-gh-mirror
ensembl-hive
Commits
a67276fa
Commit
a67276fa
authored
Sep 28, 2013
by
Leo Gordon
Browse files
moved stringification of analysis.parameters into Analysis object
parent
5c57bedf
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
7 additions
and
3 deletions
+7
-3
modules/Bio/EnsEMBL/Hive/Analysis.pm
modules/Bio/EnsEMBL/Hive/Analysis.pm
+6
-1
modules/Bio/EnsEMBL/Hive/PipeConfig/HiveGeneric_conf.pm
modules/Bio/EnsEMBL/Hive/PipeConfig/HiveGeneric_conf.pm
+1
-2
No files found.
modules/Bio/EnsEMBL/Hive/Analysis.pm
View file @
a67276fa
...
...
@@ -39,6 +39,8 @@ use strict;
use
Bio::EnsEMBL::Utils::
Argument
('
rearrange
');
use
Bio::EnsEMBL::Hive::
Utils
('
stringify
');
use
base
(
'
Bio::EnsEMBL::Storable
',
# inherit dbID(), adaptor() and new() methods
);
...
...
@@ -82,7 +84,10 @@ sub module {
sub
parameters
{
my
$self
=
shift
;
$self
->
{'
_parameters
'}
=
shift
if
(
@
_
);
if
(
@
_
)
{
my
$parameters
=
shift
@_
;
$self
->
{'
_parameters
'}
=
ref
(
$parameters
)
?
stringify
(
$parameters
)
:
$parameters
;
}
return
$self
->
{'
_parameters
'};
}
...
...
modules/Bio/EnsEMBL/Hive/PipeConfig/HiveGeneric_conf.pm
View file @
a67276fa
...
...
@@ -62,7 +62,6 @@ use warnings;
use
Bio::EnsEMBL::
ApiVersion
();
use
Bio::EnsEMBL::Hive::
Utils
('
stringify
');
use
Bio::EnsEMBL::Hive::Utils::
URL
;
use
Bio::EnsEMBL::Hive::DBSQL::
DBAdaptor
;
use
Bio::EnsEMBL::Hive::DBSQL::
SqlSchemaAdaptor
;
...
...
@@ -579,7 +578,7 @@ sub run {
$analysis
=
Bio::EnsEMBL::Hive::
Analysis
->
new
(
-
logic_name
=>
$logic_name
,
-
module
=>
$module
,
-
parameters
=>
stringify
(
$parameters_hash
),
# have to stringify it here, because Analysis code is external wrt Hive code
-
parameters
=>
$parameters_hash
,
-
resource_class_id
=>
$rc_id
,
-
failed_job_tolerance
=>
$failed_job_tolerance
,
-
max_retry_count
=>
$max_retry_count
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment