Skip to content
Snippets Groups Projects
Commit a67276fa authored by Leo Gordon's avatar Leo Gordon
Browse files

moved stringification of analysis.parameters into Analysis object

parent 5c57bedf
No related branches found
No related tags found
No related merge requests found
...@@ -39,6 +39,8 @@ use strict; ...@@ -39,6 +39,8 @@ use strict;
use Bio::EnsEMBL::Utils::Argument ('rearrange'); use Bio::EnsEMBL::Utils::Argument ('rearrange');
use Bio::EnsEMBL::Hive::Utils ('stringify');
use base ( 'Bio::EnsEMBL::Storable', # inherit dbID(), adaptor() and new() methods use base ( 'Bio::EnsEMBL::Storable', # inherit dbID(), adaptor() and new() methods
); );
...@@ -82,7 +84,10 @@ sub module { ...@@ -82,7 +84,10 @@ sub module {
sub parameters { sub parameters {
my $self = shift; my $self = shift;
$self->{'_parameters'} = shift if(@_); if(@_) {
my $parameters = shift @_;
$self->{'_parameters'} = ref($parameters) ? stringify($parameters) : $parameters;
}
return $self->{'_parameters'}; return $self->{'_parameters'};
} }
......
...@@ -62,7 +62,6 @@ use warnings; ...@@ -62,7 +62,6 @@ use warnings;
use Bio::EnsEMBL::ApiVersion (); use Bio::EnsEMBL::ApiVersion ();
use Bio::EnsEMBL::Hive::Utils ('stringify');
use Bio::EnsEMBL::Hive::Utils::URL; use Bio::EnsEMBL::Hive::Utils::URL;
use Bio::EnsEMBL::Hive::DBSQL::DBAdaptor; use Bio::EnsEMBL::Hive::DBSQL::DBAdaptor;
use Bio::EnsEMBL::Hive::DBSQL::SqlSchemaAdaptor; use Bio::EnsEMBL::Hive::DBSQL::SqlSchemaAdaptor;
...@@ -579,7 +578,7 @@ sub run { ...@@ -579,7 +578,7 @@ sub run {
$analysis = Bio::EnsEMBL::Hive::Analysis->new( $analysis = Bio::EnsEMBL::Hive::Analysis->new(
-logic_name => $logic_name, -logic_name => $logic_name,
-module => $module, -module => $module,
-parameters => stringify($parameters_hash), # have to stringify it here, because Analysis code is external wrt Hive code -parameters => $parameters_hash,
-resource_class_id => $rc_id, -resource_class_id => $rc_id,
-failed_job_tolerance => $failed_job_tolerance, -failed_job_tolerance => $failed_job_tolerance,
-max_retry_count => $max_retry_count, -max_retry_count => $max_retry_count,
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment